Fold getToolboxVersion into exportForGit; report GECKO instead of COBRA#635
Merged
Conversation
getToolboxVersion was only used by exportForGit, so it becomes a local subfunction there and the standalone file (and its doc) are removed. The dependency report now covers RAVEN and, for enzyme-constrained models (those with an "ec" field), GECKO; the COBRA Toolbox version is no longer reported. GECKO is located via GECKOInstaller.m. The tIO test that called getToolboxVersion directly now checks that exportForGit writes a RAVEN_toolbox entry to dependencies.txt instead.
Drop the git describe/commit-hash fallback in the folded getToolboxVersion: the reported version now comes solely from the toolbox version.txt, and is 'unknown' when that file is absent (e.g. a development checkout between releases).
Function test results191 tests 171 ✅ 39s ⏱️ Results for commit 3f5f0e7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getToolboxVersionwas used only byexportForGit(plus one test). It is folded in as a local subfunction, and the standaloneio/getToolboxVersion.m(and its generated doc) is removed.The dependency report in
dependencies.txtis simplified:isfield(model,'ec')), located viaGECKOInstaller.mTest
The
tIOtest that previously calledgetToolboxVersiondirectly now exercises the embedded lookup throughexportForGit, verifying aRAVEN_toolboxentry is written todependencies.txt.Verification
dependencies.txtcontainsRAVEN_toolbox, noGECKO_toolbox, no COBRA line.model.ecpresent) →GECKO_toolboxline is written.tIOpasses (18/19; 1 filtered for missing pyyaml, 0 failures).