Fix tIO/getFullPathReturnsAbsolute on non-Windows CI runner#628
Merged
Conversation
- tIO/getFullPathReturnsAbsolute: the absolute-path check was Windows-only (looked for a ":"); accept Unix absolute paths (leading "/") too.
edkerk
force-pushed
the
test/fix-linux-ci-function-tests
branch
from
908f3ba to
7b1833c
Compare
edkerk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a function test that fails on a non-Windows runner, surfaced by the GitHub-hosted CI (#624).
tIO/getFullPathReturnsAbsolute— the absolute-path assertion was Windows-only (contains(p, ':')). On Linux/macOS an absolute path is/home/...(no colon), so the test failed spuriously. It now checks a drive-letter/UNC prefix on Windows and a leading/on Unix/macOS.Verification
Passes on Windows (drive-letter branch); the Unix branch checks a leading
/.