feat(cmd): add vocab runtime plumbing#12
Merged
mdheller merged 1 commit intofeat/vocab-surfacefrom Apr 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #11.
This PR moves the new
vocabcommand surface from raw placeholder emission into real internal runtime plumbing.Included
internal/exec/runner.goexecution helperinternal/vocab/vocab.gointernal vocabulary/runtime packageinternal/vocab/vocab_test.gointernal/cmd/vocab.goupdated to delegate into the internal package instead of hardcoding response mapsWhy
PR #11 establishes the runtime-facing
vocabfaçade. This follow-on PR gives it an internal package seam so later work can wire real execution, policy-pack validation, and CI hooks without bloating the Cobra command file.Scope
Still intentionally narrow:
Review order