feat: add glossaries support and fix URI/account ID handling (MCPSRV-45)#14
Merged
Conversation
…ling - Add glossaries command group (list, create, export, import) with all flags validated against smartling-cli 3.4 source code - Inject SMARTLING_ACCOUNT_ID env var as -a flag automatically — the CLI has no native env var for account ID, causing files push and other commands to fail without it - Fix file URI convention: always specify explicit URI without /smartling prefix on push, always use --directory /smartling on pull — Go's filepath.Join would otherwise produce double-path output files - Update README, CLAUDE.md, and tool description accordingly Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for visibility. We wrap new version of smartling cli tool
Summary
list,create,export,import) with flags validated against smartling-cli 3.4 source code (corrected--file-typevs wrong--output-format, added--verification-mode,--focus-locale,--skip-entries)SMARTLING_ACCOUNT_IDenv var is now injected as-aflag automatically by the MCP server; the CLI has no native env var for this, causingfiles push,projects list,glossaries *and most other commands to fail/smartling/prefix, pull must use--directory /smartling; Go'sfilepath.Joinproduces double-path output (/smartling/smartling/...) otherwiseTest plan
glossaries listworksfiles push /smartling/<file> <uri>uploads with correct URI in Smartlingfiles pull --directory /smartlingwrites translated files back to the mounted directorySMARTLING_ACCOUNT_IDenv var in Docker config eliminates "AccountUID cannot be empty" errors🤖 Generated with Claude Code