Upgrade Cassandra Driver to 4.3.1#26
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage ? 55.25%
Complexity ? 84
=========================================
Files ? 11
Lines ? 552
Branches ? 46
=========================================
Hits ? 305
Misses ? 221
Partials ? 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeff-blaisdell
force-pushed
the
upgrade-cass-4_3
branch
from
ed6ee0d to
43ff88e
Compare
| testCompile 'org.objenesis:objenesis:2.4' | ||
| testRuntime 'io.netty:netty-all:4.1.4.Final' | ||
| testRuntime 'ch.qos.logback:logback-classic:1.1.7' | ||
| testCompile 'org.cassandraunit:cassandra-unit:4.2.2.0-SNAPSHOT' |
There was a problem hiding this comment.
| ); | ||
|
|
||
| updateLock = session.prepare( | ||
| SimpleStatement.newInstance("UPDATE databasechangelock USING TTL :ttl SET lockedby = :owner WHERE id = :lockId IF lockedby = :ifowner") |
There was a problem hiding this comment.
This is a bit obnoxious. All the bind variable - set by name methods appear only to support setting the first occurrence.
See:
https://github.com/datastax/java-driver/blob/4.x/core/src/main/java/com/datastax/oss/driver/api/core/data/SettableByName.java
Best solution I've determined so far is just make each bind name unique.. Couldn't find a method/impl that automagically set them all. If you leave it the same it results in a RuntimeException essentially saying you have unset binds.
| ResultSet rs = session.execute(insertLock.bind().setInt("lockId", lockId) | ||
| .setInt("ttl", ttl).setString("owner", owner)); | ||
| ResultSet rs = session.execute( | ||
| insertLock.boundStatementBuilder() |
There was a problem hiding this comment.
Switched bind to boundStatementBuilder to reduce cost of data copy due to immutable internal implementation.
jeff-blaisdell
force-pushed
the
upgrade-cass-4_3
branch
from
43ff88e to
73ebc18
Compare
|
|
||
| hints_directory: /tmp/hints | ||
|
|
||
| cdc_raw_directory: build/embeddedCassandra/raw |
There was a problem hiding this comment.
Required to start cassandra-unit's embedded cass after version upgrade.
| assert column.keyspace == keyspace | ||
| [column.name, row.getString(column.name)] | ||
| assert column.keyspace.asCql(true) == keyspace | ||
| [column.name.asCql(true), row.getString(column.name)] |
There was a problem hiding this comment.
column.keyspace and column.name no longer strings. Later cassandra driver introduces a wrapper type CqlIdentifer.
| Cluster.Builder builder = Cluster.builder().addContactPoint(host).withPort(port).withMaxSchemaAgreementWaitSeconds(20).withQueryOptions(queryOptions); | ||
| CqlSessionBuilder builder = CqlSession.builder() | ||
| .addContactPoint(new InetSocketAddress(host, port)) | ||
| .withLocalDatacenter(localDatacenter) |
There was a problem hiding this comment.
Cassandra Driver 4.3 will fail to startup when a host / port is specified without also setting the local datacenter field. Added it as a settable parameter w/ a default of "datacenter1" which matches the drivers default value.
This has more details:
https://docs.datastax.com/en/developer/java-driver/4.2/manual/core/load_balancing/
Reading of the docs seems that as we upgrade to the 4.x drivers we should be setting this field in higher environments.. Though I'm a little unsure to what. Could use some feedback here from those closer to Cassandra.
jeff-blaisdell
force-pushed
the
upgrade-cass-4_3
branch
from
73ebc18 to
e8bb261
Compare
2 participants
This MR upgrades the Cassandra Migration project to use the latest Cassandra Java driver (4.3.1). It contains many breaking changes from the 3.2.0 version currently in use. As a result of the upgrade the hard dependency on Guava 19.0 has been dropped. The 4.3.1 variant of Cassandra driver shades this to
com.datastax.oss.driver.shaded.guava.commonSee:
https://github.com/datastax/java-driver/tree/4.x/upgrade_guide
and
https://docs.datastax.com/en/developer/java-driver/4.3/
This bumps version to
0.2.0. Additionally, I made a0.1.x-masterto track previous version.