CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability by pegor-karoglanian · Pull Request #2416 · SmartThingsCommunity/SmartThingsEdgeDrivers

pegor-karoglanian · 2025-09-19T19:25:12Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

CLAassistant · 2025-09-19T19:25:19Z

All committers have signed the CLA.

github-actions · 2025-09-19T19:25:37Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-09-19T19:26:30Z

Channel deleted.

github-actions · 2025-09-19T19:28:56Z

Test Results

71 files 489 suites 0s ⏱️
2 517 tests 2 517 ✅ 0 💤 0 ❌
4 316 runs 4 316 ✅ 0 💤 0 ❌

Results for commit 103a7a7.

♻️ This comment has been updated with latest results.

github-actions · 2025-09-19T19:28:58Z

zigbee-lock_coverage.xml

File	Coverage
All files	`86%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua	`64%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/init.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/yale/init.lua	`81%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/samsungsds/can_handle.lua	`50%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/yale-bad-battery-reporter/can_handle.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/lock-without-codes/can_handle.lua	`77%`	❌

zwave-lock_coverage.xml

File	Coverage
All files	`87%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua	`64%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/init.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/yale/init.lua	`81%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/samsungsds/can_handle.lua	`50%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/yale/yale-bad-battery-reporter/can_handle.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/using-new-capabilities/lock-without-codes/can_handle.lua	`77%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/zwave-alarm-v1-lock/init.lua	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/schlage-lock/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/init.lua	`77%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/init.lua	`86%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/new_lock_utils.lua	`85%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/samsung-lock/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/samsung-lock/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/zwave-alarm-v1-lock/init.lua	`89%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-new-capabilities/keywe-lock/init.lua	`87%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/schlage-lock/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/using-old-capabilities/keywe-lock/init.lua	`77%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 103a7a7

pegor-karoglanian · 2025-12-10T23:17:28Z

12/10 update: Converted this PR to draft since a lot more is now going in. The latest commit adds all the commands for lockUsers and lockCredentials along with unit tests covering most of them. There are still more test cases I need to add and to tweak some of the functionality.

pegor-karoglanian requested a review from greens September 19, 2025 19:25

greens reviewed Sep 19, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

greens reviewed Sep 19, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch 2 times, most recently from b8168d4 to 36fa094 Compare September 29, 2025 20:25

pegor-karoglanian marked this pull request as ready for review September 29, 2025 20:26

pegor-karoglanian requested review from tpmanley and wkhenon September 29, 2025 20:46

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from 36fa094 to b303430 Compare September 29, 2025 20:47

greens reviewed Sep 29, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua Outdated

greens reviewed Sep 29, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

greens reviewed Sep 29, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

greens reviewed Sep 30, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_slga_migration.lua Outdated

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch 3 times, most recently from ecdc2be to c248678 Compare September 30, 2025 22:29

tpmanley reviewed Sep 30, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

greens reviewed Sep 30, 2025

View reviewed changes

Comment thread drivers/SmartThings/zwave-lock/src/init.lua Outdated

greens reviewed Sep 30, 2025

View reviewed changes

Comment thread drivers/SmartThings/zwave-lock/src/init.lua Outdated

wkhenon reviewed Oct 1, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from be53bc5 to 1230bdd Compare December 2, 2025 19:16

tpmanley reviewed Dec 2, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/init.lua Outdated

pegor-karoglanian marked this pull request as draft December 10, 2025 23:16

greens reviewed Dec 11, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/using-old-capabilities/init.lua

greens reviewed Dec 11, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/new_lock_utils.lua Outdated

greens reviewed Dec 11, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua Outdated

greens reviewed Dec 11, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/using-new-capabilities/init.lua Outdated

pegor-karoglanian commented Dec 11, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/using-old-capabilities/samsungsds/init.lua Outdated

CHAD-16364: SLGA Zigbee: Add lockUsers and lockCredentials capabilities

9c7d6f9

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from 62e48ca to 9c7d6f9 Compare December 22, 2025 23:13

pegor-karoglanian changed the title ~~CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials to profiles and also implement lockCodes:migrate functionality.~~ CHAD-16364 & CHAD-16365: Add lockUsers and lockCredentials capability Dec 22, 2025

Pegor added 2 commits December 22, 2025 15:27

Add reload command to samsung subdriver

16cd903

Add a way to test the old capabilities.

906e247

pegor-karoglanian commented Dec 23, 2025

View reviewed changes

Comment thread drivers/SmartThings/zigbee-lock/src/test/test_zigbee_lock_code_migration.lua

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from bff6478 to ada5f59 Compare December 24, 2025 02:43

greens and others added 13 commits January 9, 2026 10:41

SLGA: Z-Wave lock update

631cd3a

Zwave - Functioning base driver

94de818

Add table load check

95279be

Z-Wave Lock: first pass at sub-drivers

27a6a01

add zigbee yale new capabilities unit test

032e950

add more zigbee yale test coverage

6425a8c

updates to z-wave sub-drivers and tests

890902e

finish sub-driver unit tests

7a8439a

lazy load sub drivers

470f666

Add supportedCredentials event

439f357

breakout can_handle for new and old capabilites

6331728

breakout sub driver for yale

f9dd904

increase init delay to wait for radio up

966847a

greens force-pushed the pegor/edgedrivers/lock_changes branch from c7bbeab to 966847a Compare January 9, 2026 18:41

pegor-karoglanian marked this pull request as ready for review January 9, 2026 19:04

Fix zigbee yale lock event reporting

7e47bef

pegor-karoglanian force-pushed the pegor/edgedrivers/lock_changes branch from a2f2232 to 7e47bef Compare January 26, 2026 20:29

Fix persist store issue

103a7a7

pegor-karoglanian closed this Apr 17, 2026

Conversation

pegor-karoglanian commented Sep 19, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

CLAassistant commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pegor-karoglanian commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading