chore: re-enable global pylint checks and resolve violations#26
Merged
Conversation
- Re-enable unused-argument, edefined-outer-name, locally-disabled, ile-ignored, suppressed-message, useless-suppression, and deprecated-pragma in .pylintrc. - Prefix unused parameters with _ in src/wod/bot/formatters.py and src/wod/bot/main.py to satisfy unused-argument rules. - Localize edefined-outer-name disables at the file level inside test files ( ests/bot/test_live_workout.py, ests/bot/test_wod.py, ests/bot/test_wod_helpers.py, ests/conftest.py, and ests/core/test_engine.py) to handle standard pytest fixture shadowing without globally ignoring the check. - Fix mock argument positions in ests/bot/test_menu.py and ests/bot/test_live_workout.py using prefix _ to satisfy both the Pylint compiler and mock @patch positional orders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edefined-outer-name, locally-disabled, ile-ignored, suppressed-message, useless-suppression, and deprecated-pragma in .pylintrc.
edefined-outer-name disables at the file level inside test files ( ests/bot/test_live_workout.py, ests/bot/test_wod.py, ests/bot/test_wod_helpers.py, ests/conftest.py, and ests/core/test_engine.py) to handle standard pytest fixture shadowing without globally ignoring the check.