Skip to content

Proof of PNNetwork.boxProd preserving SimplePN#16

Open
chi-p-3141 wants to merge 2 commits intoShreyas4991:mainfrom
chi-p-3141:tests
Open

Proof of PNNetwork.boxProd preserving SimplePN#16
chi-p-3141 wants to merge 2 commits intoShreyas4991:mainfrom
chi-p-3141:tests

Conversation

@chi-p-3141
Copy link
Copy Markdown
Contributor

The proof is pretty long and probably doesn't need to be, but it works. Any suggestions to make it nicer would be welcome. (ie ways to do simultaneous simp on only two specific hypotheses)

Going to try to do the same lemma in PNNetworkExperimental if I can wrap my head around heterogeneous equalities.

Comment thread DGAlgorithms/Network/PNNetwork.lean Outdated
Comment thread DGAlgorithms/Network/PNNetwork.lean Outdated
Comment thread DGAlgorithms/Network/PNNetwork.lean Outdated
Copy link
Copy Markdown
Owner

@Shreyas4991 Shreyas4991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting notes on case splits and indentation of the proofs of individual cases and have statements.

Comment on lines +452 to +453
constructor
-- loopless
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When starting a case analysis using cases or constructors, you should use the case selector notation. For constructor, by_cases, split, and split_ifs, the . case selector is preferred although you can also use case <case name from goal state> <additional variable introduced in this case> => proof. For cases .. with and induction .. with I suggest using the code action that vscode shows (keyboard shortcut : Ctrl + . and letting it create the arms of the proof for you. In either case the proof of the case is indented more than the proof outside. Similarly proofs of haves should have an extra indentation to clearly show that they are proofs of the have statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants