Simplify nesting_stack_to_name_id name creation#750
Open
vinistock wants to merge 1 commit into04-16-fix_singleton_name_creation_for_nestingfrom
Open
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
04-16-simplify_nesting_stack_to_name_id_name_creation
branch
from
79fa11d to
97b0fef
Compare
vinistock
force-pushed
the
04-16-fix_singleton_name_creation_for_nesting
branch
from
48fcde4 to
3afccea
Compare
vinistock
force-pushed
the
04-16-simplify_nesting_stack_to_name_id_name_creation
branch
from
97b0fef to
822623d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in this PR stack, the method for creating names started getting a bit repetitive. This PR extracts a helper method to simplify the code a bit.