Add CLI support for order_attribution_config extension type#7322
Merged
Catherine-Fu merged 2 commits intomainfrom Apr 16, 2026
Merged
Add CLI support for order_attribution_config extension type#7322Catherine-Fu merged 2 commits intomainfrom
Catherine-Fu merged 2 commits intomainfrom
Conversation
Register the order_attribution_config extension type in the CLI so developers can generate and deploy this extension type. Follows the same pattern as channel_config with copy_files build config for SVG icons in the icons/ subdirectory. Closes shop/issues-multi-channel-management#3127 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new local extension specification for order_attribution_config and registers it so the CLI can load it like other contract-based module specs.
Changes:
- Added
order_attribution_configcontract-based module specification withuidStrategy: 'single'andexperience: 'extension'. - Configured deploy/build to include
icons/**/*.svgviacopy_files+include_assetsclient step. - Registered the new specification in
load-specifications.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/app/src/cli/models/extensions/specifications/order_attribution_config.ts |
Introduces the new contract-based module spec and asset-copy configuration for SVG icons. |
packages/app/src/cli/models/extensions/load-specifications.ts |
Imports and adds the new spec to the locally loaded moduleSpecs list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsmarr
approved these changes
Apr 16, 2026
kott
approved these changes
Apr 16, 2026
Catherine-Fu
changed the title
isaacroldan
reviewed
Apr 16, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isaacroldan
approved these changes
Apr 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
order_attribution_configspecification inpackages/app/src/cli/models/extensions/specifications/order_attribution_config.tsload-specifications.tscreateContractBasedModuleSpecificationwithcopy_filesbuild config for SVG icons (same pattern aschannel_config)Changes
order_attribution_config.ts— specification withuidStrategy: 'single',experience: 'extension', copiesicons/**/*.svgon deployload-specifications.ts— import and register the new spec inmoduleSpecsTest plan
shopify app generate extensionlistsorder_attribution_configas an optionshopify app deploysucceeds with the new extension typeCloses https://github.com/shop/issues-multi-channel-management/issues/3127
🤖 Generated with Claude Code