Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-webhook-trigger-typo.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Fix "Localhost delivery sucessful" → "Localhost delivery successful" typo in the success message printed by `shopify app webhook trigger --delivery-method=localhost`.
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/app/config/link.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export async function overwriteLocalConfigFileWithRemoteAppConfiguration(options
},
replaceLocalArrayStrategy,
),
// Always use our prefered build options
// Always use our preferred build options
build: buildOptionsForGeneratedConfigFile({
existingBuildOptions: localAppOptions.existingBuildOptions,
linkedAppAndClientIdFromFileAreInSync: localAppOptions.localAppIdMatchedRemote,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('when there are locale files', () => {
})
vi.useRealTimers()
})
test('returns the last succesful locale built when there are JSON errors', async () => {
test('returns the last successful locale built when there are JSON errors', async () => {
const timestamp = 0
vi.setSystemTime(new Date(timestamp))

Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/webhook/trigger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ describe('webhookTriggerService', () => {
anOrganizationId,
)
expect(triggerLocalWebhook).toHaveBeenCalledWith(aFullLocalAddress, samplePayload, sampleHeaders)
expect(outputSuccess).toHaveBeenCalledWith('Localhost delivery sucessful')
expect(outputSuccess).toHaveBeenCalledWith('Localhost delivery successful')
})

test('shows an error if localhost is not ready', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/webhook/trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ async function sendSample(options: WebhookTriggerOptions) {
const result = await triggerLocalWebhook(options.address, sample.samplePayload, sample.headers)

if (result) {
outputSuccess('Localhost delivery sucessful')
outputSuccess('Localhost delivery successful')
return
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-kit/src/public/node/context/local.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ describe('cloudEnvironment', () => {
expect(got.platform).toBe('gitpod')
})

test('returns localhost when no cloud enviroment varible exist', () => {
test('returns localhost when no cloud environment variable exists', () => {
// Given
const env = {}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-kit/src/public/node/json-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ function simplifyUnionErrors(rawErrors: AjvError[], subject: object, schema: Sch
// we start by assuming only the union error itself is useful, and not the errors from the candidate schemas
let simplifiedUnionRelatedErrors: AjvError[] = [unionError]

// get the schema list from where the union issue occured
// get the schema list from where the union issue occurred
const dottedSchemaPath = unionError.schemaPath.replace('#/', '').replace(/\//g, '.')
const unionSchemas = getPathValue<SchemaObject[]>(schema, dottedSchemaPath)
// and the slice of the subject that caused the issue
Expand Down
2 changes: 1 addition & 1 deletion packages/theme/src/cli/utilities/repl/evaluator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('evaluate', () => {
})
})

test('should add succesful assignments to the session', async () => {
test('should add successful assignments to the session', async () => {
const mockResponse = createMockResponse({
status: 200,
text: '<div id="shopify-section-announcement-bar" class="shopify-section">\n[{ "type": "context", "value": "assign x = 1" }]</div>',
Expand Down
2 changes: 1 addition & 1 deletion packages/theme/src/cli/utilities/theme-uploader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ function buildUploadJob(
Promise.resolve(),
)

// Dependant and independant files are uploaded concurrently
// Dependent and independent files are uploaded concurrently
const independentFilesUploadPromise = Promise.resolve().then(() => uploadFileBatches(independentFiles.flat()))

const promise = Promise.all([dependentFilesUploadPromise, independentFilesUploadPromise]).then(() => {
Expand Down
Loading