Skip to content

Raise Swift iOS deployment target to 15#271

Draft
kieran-osgood-shopify wants to merge 2 commits into
mainfrom
cx-remove-ios13-14-support
Draft

Raise Swift iOS deployment target to 15#271
kieran-osgood-shopify wants to merge 2 commits into
mainfrom
cx-remove-ios13-14-support

Conversation

@kieran-osgood-shopify

Copy link
Copy Markdown
Contributor

What changes are you making?

Raise the Swift Checkout Kit iOS deployment floor from iOS 13 to iOS 15 across SwiftPM and CocoaPods metadata, update the Swift API digester target, and refresh Swift docs.

This also removes now-unnecessary iOS < 15 compatibility branches in the Swift SDK/sample code, and aligns the React Native iOS podspec/README minimum because the RN iOS pod depends on the native Swift ShopifyCheckoutKit pod.

How to test

  • shadowenv exec --dir <repo_root> -- grep -R "iOS 13\|ios13\|\.iOS(.v13)\|deployment_target = \"13.0\"" Package.swift ShopifyCheckoutKit.podspec platforms/swift platforms/react-native/modules/@shopify/checkout-kit-react-native/RNShopifyCheckoutKit.podspec platforms/react-native/README.md — no matches
  • shadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift test — passed
  • shadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift build — passed
  • shadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift lint — passed
  • shadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift api check — passed; no API baseline updates required
  • shadowenv exec --dir <repo_root> -- /opt/dev/bin/dev react-native lint — passed

Before you merge

Important

  • I have added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I have updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant