Raise Swift iOS deployment target to 15#271
Draft
kieran-osgood-shopify wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Raise the Swift Checkout Kit iOS deployment floor from iOS 13 to iOS 15 across SwiftPM and CocoaPods metadata, update the Swift API digester target, and refresh Swift docs.
This also removes now-unnecessary iOS < 15 compatibility branches in the Swift SDK/sample code, and aligns the React Native iOS podspec/README minimum because the RN iOS pod depends on the native Swift
ShopifyCheckoutKitpod.How to test
shadowenv exec --dir <repo_root> -- grep -R "iOS 13\|ios13\|\.iOS(.v13)\|deployment_target = \"13.0\"" Package.swift ShopifyCheckoutKit.podspec platforms/swift platforms/react-native/modules/@shopify/checkout-kit-react-native/RNShopifyCheckoutKit.podspec platforms/react-native/README.md— no matchesshadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift test— passedshadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift build— passedshadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift lint— passedshadowenv exec --dir <repo_root> -- /opt/dev/bin/dev swift api check— passed; no API baseline updates requiredshadowenv exec --dir <repo_root> -- /opt/dev/bin/dev react-native lint— passedBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.