[Swift] Add runtime iOS version to user agent#270
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Conversation
kieran-osgood-shopify
changed the title
React Native — Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This PR updates the Swift Checkout Kit user-agent suffix so checkout WebView traffic and Accelerated Checkouts GraphQL traffic include the actual runtime iOS version.
What?
iOSVersion/<UIDevice.current.systemVersion>token to the existingShopifyCheckoutKit/... (iOS;Swift ...)metadata suffix.UserAgentTestsexpected strings to include the dynamic runtime iOS version.Why?
WebKit/Safari can report a frozen built-in iOS user-agent value such as
18_7, which makes iOS 26 traffic difficult to distinguish. Checkout Kit already appends a custom user-agent suffix through the sharedUserAgent.string(...)path, so adding a stable machine-readable token there gives observability the actual runtime iOS version without changing public API.Validation
shadowenv exec --dir /Users/ko/.claudex/worktrees/Shopify@checkout-kit/cx-ios-version-user-agent -- /opt/dev/bin/dev swift test UserAgentTestsshadowenv exec --dir /Users/ko/.claudex/worktrees/Shopify@checkout-kit/cx-ios-version-user-agent -- /opt/dev/bin/dev swift lintshadowenv exec --dir /Users/ko/.claudex/worktrees/Shopify@checkout-kit/cx-ios-version-user-agent -- /opt/dev/bin/dev swift api check