Skip to content

Develop#653

Merged
ShaneIsrael merged 3 commits into
mainfrom
develop
Jun 4, 2026
Merged

Develop#653
ShaneIsrael merged 3 commits into
mainfrom
develop

Conversation

@ShaneIsrael

Copy link
Copy Markdown
Owner

This pull request introduces a few targeted improvements to file upload validation, media metadata extraction, and utility robustness. The most significant changes are the stricter validation of folder names during uploads, enhanced extraction of image creation dates using EXIF metadata, and improved command construction for ffprobe invocations.

File upload validation:

  • Tightened folder name validation in all upload endpoints (public_upload_video, public_upload_videoChunked, upload_video, upload_videoChunked) to reject folder names containing spaces, in addition to slashes and parent directory references. This helps prevent accidental or malicious folder naming issues. [1] [2] [3] [4]
  • Updated secure_filename in helpers.py to replace whitespace characters with hyphens, further sanitizing filenames.

Media metadata extraction and utility improvements:

  • Added robust extraction of image creation dates using EXIF metadata in util.py (extract_date_from_image_file and _extract_date_from_image_exif), with fallback to filename patterns and file modification time. Updated scan_image in cli.py to use this improved extraction method. [1] [2]
  • Refactored ffprobe command construction in get_media_info and _extract_date_from_metadata to use argument lists instead of string splitting, improving reliability and error handling. [1] [2]

Other improvements:

  • Fixed a bug in create_posters where a missing duration could cause a crash, by defaulting to zero if the video duration is None.
  • Incremented the client version to 1.6.14 in both package.json and package-lock.json. [1] [2]

@ShaneIsrael ShaneIsrael merged commit 3000fc9 into main Jun 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant