feat: add battery/power source module for issue #52#55
Open
ShadyUnderLight wants to merge 1 commit intomainfrom
Open
feat: add battery/power source module for issue #52#55ShadyUnderLight wants to merge 1 commit intomainfrom
ShadyUnderLight wants to merge 1 commit intomainfrom
Conversation
- Add BatteryStatus enum and PowerSourceInfo struct to SystemModels - Add .power flag to PopupModuleVisibility - Add PowerSourceProvider using IOKit to read battery state - SystemSummary now includes powerSource from SystemMetricsProvider - MenuBarContentView shows battery section when .power enabled and hasBattery - Localization strings for battery status and time remaining (en/zh-Hans) - 6 unit tests for PowerSourceInfo formatting and localization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatteryStatusenum (charging/discharging/full/noBattery) andPowerSourceInfostruct.powerflag toPopupModuleVisibilityOptionSetPowerSourceProviderusing IOKit to read battery state (percent, charging status, time remaining)SystemSummarynow includespowerSource: PowerSourceInfofromSystemMetricsProviderMenuBarContentViewshows battery section only when.powerenabled AND device has a batteryPowerSourceInfoformatting and localizationAcceptance criteria
Testing