Skip to content

feat: support display templates and popup module visibility for issue #48#54

Merged
ShadyUnderLight merged 2 commits intomainfrom
feat/issue48-display-template-modules
Apr 29, 2026
Merged

feat: support display templates and popup module visibility for issue #48#54
ShadyUnderLight merged 2 commits intomainfrom
feat/issue48-display-template-modules

Conversation

@ShadyUnderLight
Copy link
Copy Markdown
Owner

Summary

  • Add MenuBarDisplayTemplate enum with minimal, standard, detailed cases
  • Add PopupModuleVisibility OptionSet with flags for sparklines, topCPU, topMemory, temperatureHint, diagnostics
  • Both persist to UserDefaults with legacy string migration support
  • SettingsView: new "Display Template" picker and "Popup Modules" toggles section
  • MenuBarContentView: sections conditionally rendered based on moduleVisibility
  • 10 new unit tests covering default values and migration paths

Acceptance criteria met

  • At least 3 menu bar display templates
  • Popup module visibility toggles
  • Settings persisted to UserDefaults
  • Legacy settings migrate or fall back to sensible defaults
  • Unit tests added for ViewModel/settings/UI behavior

Testing

  • All 120 tests pass
  • Build succeeds

LMZ added 2 commits April 29, 2026 17:45
- Add MenuBarDisplayTemplate enum (minimal/standard/detailed)
- Add PopupModuleVisibility OptionSet (sparklines, topCPU, topMemory, temperatureHint, diagnostics)
- Both persist to UserDefaults with migration from legacy strings
- SettingsView adds template picker and module toggles
- MenuBarContentView conditionally renders sections based on moduleVisibility
- 10 new unit tests for default values and migration paths
…y section, gate diagnostics button

- menuBarTitle now switches on displayTemplate instead of menuBarDisplayMode:
  minimal = compact (cpu mem temp), standard = labeled (CPU/labeled), detailed = temperatureFirst
- Remove duplicate Top Memory section that bypassed moduleVisibility
- Gate Copy Diagnostics button behind .diagnostics flag
- 3 new tests for displayTemplate default/migration
@ShadyUnderLight ShadyUnderLight merged commit a74f5c4 into main Apr 29, 2026
2 checks passed
@ShadyUnderLight ShadyUnderLight deleted the feat/issue48-display-template-modules branch April 29, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant