Skip to content

fix: remove unguarded exit(0) fallback from quit flow (issue #35) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadyUnderLight merged 1 commit into from
Apr 21, 2026
Merged

fix: remove unguarded exit(0) fallback from quit flow (issue #35) #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Sources/ProcessBarMonitor/Views.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,14 @@ struct MenuBarContentView: View {
window.close()
}

// Standard macOS termination. The 0.5 s + exit(0) fallback that existed here
// was added without a linked issue or documented reproduction, and stop() has no
// persistent background work that would prevent terminate from succeeding.
// If a future regression shows terminate is insufficient, re-add the fallback
// only with a comment explaining the specific failure mode and a tracking issue.
DispatchQueue.main.async {
NSApp.terminate(nil)
}

DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
exit(0)
}
}

private var memorySummary: String {
Expand Down