fixed all the issues with name colors#8
Open
Yanzinator wants to merge 2 commits into
Open
Conversation
added having a rank replaces the original rank, and fixed the lag issue whenever messages happened. also cleaned a lil bit of the color change logic but it's still broken and I can't figure out why the hell.
still not sure why my fix worked and why it didn't work before
Yanzinator
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added having a rank replaces the original rank, and fixed the lag issue whenever messages happened. also cleaned a lil bit of the color change logic but it's still broken and I can't figure out why the hell.
I fixed it but i still dont know why the hell it was.