Remove read_timeout from S3 client#35
Open
rdettai-sk wants to merge 2 commits intosekoiafrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjust multipart upload defaults to avoid timeouts on large uploads by reducing the default target part size.
Changes:
- Update
MultiPartPolicydefaulttarget_part_num_bytesfrom 5GB to 2GB. - Refresh the inline rationale comment for the default part sizing choice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+70
to
+74
| // QW originally used 5GB to limit the number of PUT requests. This | ||
| // is a bit excessive, and many cloud providers don't bill by | ||
| // request. We don't want it to be too small either because parts | ||
| // incure a performance overhead when a range request spans 2 parts. | ||
| target_part_num_bytes: 2_000_000_000, // 2GB |
There was a problem hiding this comment.
The PR title/description mention removing read_timeout from the S3 client, but this change only adjusts the default multipart target part size. Please align the PR title/description with the actual change (or include the missing read_timeout removal if it was intended).
| // QW originally used 5GB to limit the number of PUT requests. This | ||
| // is a bit excessive, and many cloud providers don't bill by | ||
| // request. We don't want it to be too small either because parts | ||
| // incure a performance overhead when a range request spans 2 parts. |
There was a problem hiding this comment.
Typo in comment: "incure" should be "incur".
Suggested change
| // incure a performance overhead when a range request spans 2 parts. | |
| // incur a performance overhead when a range request spans 2 parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had some timeouts when uploading larger merged splits.
With the 900s timeout configured in #27, the hard coded part size of 5GB is too big (times out if bandwidth <5MB/s). It seems more robust to decrease the part size than increase this generous timeout even further.