Generate correct imports in frontend format#3037
Merged
tyt2y3 merged 5 commits intoSeaQL:masterfrom Apr 22, 2026
Merged
Conversation
Contributor
Author
|
Forgot to run the whole test suite, so I missed those failing tests. Hopefully they're fixed now |
Contributor
Author
|
Any update on this? |
Member
|
sorry for the late reply, I'll take a look |
tyt2y3
reviewed
Apr 21, 2026
tyt2y3
reviewed
Apr 21, 2026
DexterHill0
force-pushed
the
fix-frontend-datetime
branch
from
bbdef96 to
384a928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Bug Fixes
--frontend-formatargument, if any model column types use external types from libraries likeUuidor any datetime types, for example, the generated code does not include the correct imports; it assumes there's apreludeimport, but that is excluded in thefrontendformat, so the types just error.Breaking Changes
Should not be a breaking change.
Notes
I added tests for this, following the existing format as best as I can.