Skip to content

fix(timeline): suppress dividers when the underlying event renders null #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −2
Open

fix(timeline): suppress dividers when the underlying event renders null #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/app/features/room/RoomTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,13 @@ export function RoomTimeline({
eventData.collapsed
);

const dividers = (
// Suppress dividers when the underlying event will not render.
// Otherwise rooms whose only events on a given day are hidden
// (e.g. announcement channels full of profile changes / joins)
// show a bare day divider with no message under it (#701).
const showDividers = renderedEvent !== null;

const dividers = showDividers ? (
<>
{eventData.willRenderDayDivider && (
<MessageBase space={messageSpacing}>
Expand All @@ -942,7 +948,7 @@ export function RoomTimeline({
</MessageBase>
)}
</>
);
) : null;

if (index === 0) {
return (
Expand Down
Loading