Open
Conversation
Collaborator
|
수고하셨습니다!! |
Collaborator
|
4주차도 수고하셨습니다 ~!! |
yangjiae12
requested changes
Apr 14, 2026
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
미션은 잘 진행해주셨는데, 리드미에 작성되어 있는 것처럼 kaka 폴더 안에 프로젝트가 들어가도록 해주시고 main 브랜치에 있는 .github도 지우지 않으셔야 합니다!
Member
There was a problem hiding this comment.
에러 코드와 성공 코드도 enum으로 만들어 주시면 됩니다!
Collaborator
Author
There was a problem hiding this comment.
이넘으로 만들었습니다! 맞춰서 kaka 폴더 안에 프로젝트 들어가게 수정을 main 브랜치 깃허브로 받도록 수정했습니다~! 감사합니다:)
…rovided diffs: ```text refactor: 모든 패키지 및 클래스를 kaka 하위 패키지로 이동 ``` **Alternative (if you prefer English):** ```text refactor: move all classes and directories under kaka sub-package ``` ### Key Changes Summarized: * Moved all existing domain and global files under `com.umc.umc10th` to the new `com.umc.umc10th.kaka` base package. * Updated package declarations in all `.java` and `.kt` files to reflect the new `kaka` directory path.
yangjiae12
reviewed
Apr 14, 2026
Collaborator
Author
There was a problem hiding this comment.
맞춰서 수정했습니다!!
**feat: 멤버 도메인 에러/성공 코드 추가 및 예외 처리 수정** ### Summary of Changes: * **`MemberException.java`**: Refactored to accept a `MemberErrorCode` instead of a plain string message, and added a `@Getter` for the error code. * **`MemberErrorCode.java`**: Added a new enum to standardize member-related error responses (e.g., `MEMBER_NOT_FOUND`, `MEMBER_ALREADY_EXISTS`) along with their corresponding HTTP statuses. * **`MemberSuccessCode.java`**: Added a new enum to standardize member-related success responses (e.g., `MEMBER_FOUND`, `MEMBER_CREATED`) along with their corresponding HTTP statuses.
refactor: Repository 클래스들을 interface로 변경 **Details of the changes:** * Changed `ReviewRepository`, `MemberRepository`, and `MissionRepository` from `class` to `interface` to properly set them up as Spring Data JPA repositories (or standard interfaces).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📁 패키지 구조