feat: cross-compile for Scala 2.12 + 2.13 with Java 17 target#10
Merged
feat: cross-compile for Scala 2.12 + 2.13 with Java 17 target#10
Conversation
Migrate generic-notification-api to support both Scala 2.12.20 and 2.13.16 with Java 17 compilation target. Bump version to 0.9.0. Key changes: - Configs → ConfigReader (configs 0.6.x), kebab-case config aliases - JavaConverters → jdk.CollectionConverters + scala-collection-compat - Stream.continually → Iterator.continually (2.13 deprecation) - Nullary method dotted invocation (.complete()) - .asScala.toSeq for mutable.Buffer compatibility - Dependencies: generic-persistence-api 0.8.1, scheduler 0.8.0, sbt-softnetwork 0.2.0, scalapb-extensions 0.2.0, slf4j 2.0.7, logback 1.4.14, sbt-scoverage 2.3.0 - CI: JDK 17, actions v4, sbt/setup-sbt@v1, cross-compile step Closed Issue #9 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 67.19% 71.16% +3.96%
==========================================
Files 30 61 +31
Lines 689 1068 +379
Branches 0 165 +165
==========================================
+ Hits 463 760 +297
- Misses 226 308 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate generic-notification-api to support both Scala 2.12.20 and 2.13.16 with Java 17 compilation target. Bump version to 0.9.0.
Key changes:
Closed Issue #9