Add CI package/publish-surface validation for workspace crates#207
Open
Add CI package/publish-surface validation for workspace crates#207
Conversation
Owner
Author
|
This PR correctly implements the package-surface validation flow for #199, but it is expected to fail until the publish dependency chain is available on crates.io. Marking it as a merge candidate once the prerequisite published crates exist and the dry-run checks can succeed as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
scripts/validate_publishable_crates.pywhich runscargo package --list --locked -p <crate>andcargo publish --dry-run --locked -p <crate>fortailtriage-core,tailtriage-tokio, andtailtriage-cli, printing per-command output and collecting failures..github/workflows/ci.ymlas aValidate publishable cratesstep on thedevmatrix profile to keep validation maintainable and scoped.Testing
cargo fmt --checkand it passed.cargo clippy --workspace --all-targets -- -D warningsand it passed.cargo test --workspaceand all tests passed.python3 scripts/validate_publishable_crates.pywhich correctly exercised the new checks and reported failures:tailtriage-coredry-run succeeded buttailtriage-tokioandtailtriage-clidry-run failed due to their dependency ontailtriage-corenot being available on crates.io, demonstrating the script surfaces publish-order assumptions as intended.Codex Task