dasp_graph: Pass edge weights to Node::process#182
Open
Smona wants to merge 6 commits intoRustAudio:masterfrom
Open
dasp_graph: Pass edge weights to Node::process#182Smona wants to merge 6 commits intoRustAudio:masterfrom
Smona wants to merge 6 commits intoRustAudio:masterfrom
Conversation
Author
|
@est31 i noticed you've merged a couple of PRs since I put this up, any appetite for merging this? This feature is pretty important for supporting e.g. sidechain inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
NodeandInputgeneric by edge weight, and passes the edge weight toprocesson eachInput, resolving a TODO in the docs.This is only implemented for weights that implement
Clone, because I could not figure out a good way to store a reference to the weight in theInputstructs due to how the processor'sinputsfield is reused. But I think this will be sufficient for the majority of use cases, where we usually just need to distinguish inputs by simple types.I think this change is backwards compatible, because the
Wtype parameter used to refer to the weight defaults to(), and I didn't have to make any changes to my (small) project after switching to this branch.Documentation is also updated.