Fix WM_DPICHANGED not triggering Resized event#140
Open
robbert-vdh wants to merge 1 commit intoRustAudio:masterfrom
Open
Fix WM_DPICHANGED not triggering Resized event#140robbert-vdh wants to merge 1 commit intoRustAudio:masterfrom
robbert-vdh wants to merge 1 commit intoRustAudio:masterfrom
Conversation
The window size gets changed directly in the `WM_DPICHANGED` handler, so comparing the new size against that will not work. The solution is to store the last size seen in `WM_SIZE` separately.
Contributor
|
Tested this on my machine (Windows 11) and it works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window size gets changed directly in the
WM_DPICHANGEDhandler, so comparing the new size against that will not work. The solution is to store the last size seen inWM_SIZEseparately.This fixes a regression from #136 affecting HiDPI displays+system scaling on Windows. @geom3trik was going to test this fix at some point, but everyone's forgotten about it since then and I just remembered that it still hasn't been fixed. I don't have a Windows HiDPI setup so I haven't tested this myself, but it should at least fix the
WindowEvent::Resizednot coming through when the system DPI changes. @geom3trik could you test this?