Compiletest: pass -Zui-testing to rustc#447
Merged
Firestar99 merged 2 commits intomainfrom Oct 22, 2025
Merged
Conversation
Contributor
|
I would squash together the 2nd and 3rd commits because they don't make sense in isolation (tests will fail if just the 2nd commit is applied). Otherwise, I'm not a rust-gpu reviewer, but LGTM. |
Member
Author
|
I was considering it, but didn't as it "hides" the " |
Firestar99
force-pushed
the
compiletest-z-ui-testing
branch
from
18c92d8 to
067b38b
Compare
Merged
Contributor
It's mentioned in the first line of the commit message! :) |
LegNeato
approved these changes
Oct 22, 2025
Collaborator
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Sweet! Thanks for doing this.
LegNeato
added a commit
to LegNeato/Rust-CUDA
that referenced
this pull request
Oct 22, 2025
This is the dual of Rust-GPU/rust-gpu#447
LegNeato
added a commit
to Rust-GPU/rust-cuda
that referenced
this pull request
Oct 22, 2025
This is the dual of Rust-GPU/rust-gpu#447
eddyb
reviewed
Oct 22, 2025
Member
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
To be perfectly honest, seeing this diff, the fact that we weren't using -Z ui-testing for the kind of tests named ui because of rustc testing infrastructure, is quite the facepalm moment 🤦.
Thanks for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #439, see discussions over there
-Zui-testingto rustc to improve compiletest normalization and have fewer conflicts