Merged
Conversation
This was referenced Oct 14, 2025
065b526 to
121a661
Compare
2143e1b to
80dda7d
Compare
Merged
80dda7d to
449c894
Compare
449c894 to
e2d766b
Compare
…vate apart from `mod float`, which contains functionality
…e it its own mod
e2d766b to
9a6d9ab
Compare
eddyb
approved these changes
Oct 22, 2025
Member
eddyb
left a comment
There was a problem hiding this comment.
Looking at this now, they could've been in a spirv_std::traits module from the start, but the consolidation from this PR is already most of the improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
VectorOrScalartoScalarOrVectorto match spec expression used in subgroup intrinsicsspirv_std::vector::VectorOrScalar->spirv_std::ScalarOrVectorspirv_std::scalar::Scalar->spirv_std::Scalarspirv_std::vector::Vector->spirv_std::Vectorspirv_std::number::Number->spirv_std::Numberspirv_std::integer::Integer->spirv_std::Integerspirv_std::integer::SignedInteger->spirv_std::SignedIntegerspirv_std::integer::UnsignedInteger->spirv_std::UnsignedIntegerspirv_std::float::Float->spirv_std::Floatspirv-stddirectlyChanges
Number,Integer,SignedInteger,UnsignedInteger,Float) tomod scalarVectorOrScalarandSealedto newmod vector_or_scalarinteger,number,sealedfloatsince it has intrinsics