Skip to content

Added new additional params for videoInference support#289

Open
Sirsho1997 wants to merge 2 commits intomainfrom
feature-P-videoAvatar
Open

Added new additional params for videoInference support#289
Sirsho1997 wants to merge 2 commits intomainfrom
feature-P-videoAvatar

Conversation

@Sirsho1997
Copy link
Copy Markdown
Collaborator

  • ISettings now includes:
    • voicePrompt: Optional[str]
    • safetyFilter: Optional[bool]

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 93006f4d-deda-4072-ae06-2fda0e71b7e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-P-videoAvatar

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SDK’s type definitions to support additional video-inference-related request parameters, primarily by extending ISettings and making IVideoInference.speech easier to provide as a plain dict (auto-coerced to the proper dataclass).

Changes:

  • Added voicePrompt and safetyFilter fields to ISettings.
  • Updated IVideoInference.speech to accept dict inputs and coerces them to IVideoSpeechSettings in __post_init__.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runware/types.py
style: Optional[str] = None
voicePrompt: Optional[str] = None
safetyFilter: Optional[bool] = None
thinking: Optional[str] = None
Comment thread runware/types.py
Comment on lines +1920 to +1921
if self.speech is not None and isinstance(self.speech, dict):
self.speech = IVideoSpeechSettings(**self.speech)
Comment thread runware/types.py
Comment on lines 1895 to 1897
providerSettings: Optional[VideoProviderSettings] = None
speech: Optional[IVideoSpeechSettings] = None
speech: Optional[Union[IVideoSpeechSettings, Dict[str, Any]]] = None
webhookURL: Optional[str] = None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants