Skip to content

Add training Task Type#52

Merged
isaacsokari merged 3 commits intomainfrom
is/add_training_support
May 7, 2026
Merged

Add training Task Type#52
isaacsokari merged 3 commits intomainfrom
is/add_training_support

Conversation

@isaacsokari
Copy link
Copy Markdown
Contributor

No description provided.

@isaacsokari isaacsokari requested review from IanLunn and YomiCasual and removed request for IanLunn May 6, 2026 14:09
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2dde5d0c-5303-4e16-aaee-27c16f5bd1e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch is/add_training_support

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Runware/Runware-base.ts`:
- Around line 1093-1095: The call to pollForAsyncResults<TTrainingResponse> is
missing a dedupe key so successful training responses never register with
getUniqueUUID; update the call in Runware-base (the return statement using
pollForAsyncResults) to provide a dedupeKey (or extractor) that yields the same
identifier getUniqueUUID expects (e.g., use request.taskUUID if that is the
training job id, or provide a function that reads the training response's
job/model id field and returns it). Ensure the dedupeKey aligns with
getUniqueUUID logic so successful TTrainingResponse objects are counted and the
poll resolves instead of timing out.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3150ba41-3019-415b-a466-0620335af684

📥 Commits

Reviewing files that changed from the base of the PR and between aeff3eb and 470f64e.

📒 Files selected for processing (4)
  • Runware/Runware-base.ts
  • Runware/types.ts
  • package.json
  • readme.md

Comment thread Runware/Runware-base.ts
@isaacsokari isaacsokari force-pushed the is/add_training_support branch from 0e2e515 to 931464c Compare May 6, 2026 15:59
@isaacsokari isaacsokari marked this pull request as ready for review May 6, 2026 16:01
@isaacsokari isaacsokari requested a review from IanLunn May 6, 2026 16:09
@isaacsokari isaacsokari merged commit b0a5048 into main May 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants