Don't attempt to install probe for socket.io v3 or v4#650
Open
frostmar wants to merge 2 commits intoRuntimeTools:masterfrom
Open
Don't attempt to install probe for socket.io v3 or v4#650frostmar wants to merge 2 commits intoRuntimeTools:masterfrom
frostmar wants to merge 2 commits intoRuntimeTools:masterfrom
Conversation
ghost
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick workaround for issue #649
I'm afraid this isn't a proper fix, and only avoids installing the socket.io probe for newer versions where that doesn't currently work.
The socket.io probe only patches in successfully with socket.io v1 and v2
If a
.Serverclass is on the socket.io export, this is probably v3+, so don't attempt to patch.