Closed
Conversation
The test was added in dc34990, it turns out that it's flaky. It failed once on the Debian build infra, cf. [1]. The problem is that the command `rsync -aH '$fromdir/sym' '$todir'` updates the mod time of `$todir`, so there might be a diff between the output of `rsync_ls_lR $fromdir` and `rsync_ls_lR $todir`, if ever rsync runs 1 second (or more) after the directories were created. To clarify: it's easy to make the test fails 100% of the times with this change: ``` makepath "$fromdir/sym" "$todir" +sleep 5 checkit "$RSYNC -aH '$fromdir/sym' '$todir'" "$fromdir" "$todir" ``` The fix proposed here is in line with other tests in hardlinks.test, as far as I can see all the tests use a trailing slash for the `$fromdir` and `$todir` arguments. I tested that, after this commit, the test still catches the regression in rsync 3.4.0. Fixes: RsyncProject#735 [1]: https://buildd.debian.org/status/fetch.php?pkg=rsync&arch=ppc64el&ver=3.4.1%2Bds1-1&stamp=1741147156&raw=0
Contributor
Author
|
Actually this approach doesn't work, it doesn't catch the -H regression in rsync-3.4.0 anymore... Closing in favor of #737. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was added in dc34990, it turns out that it's flaky. It failed once on the Debian build infra, cf. 1.
The problem is that the command
rsync -aH '$fromdir/sym' '$todir'updates the mod time of$todir, so there might be a diff between the output ofrsync_ls_lR $fromdirandrsync_ls_lR $todir, if ever rsync runs 1 second (or more) after the directories were created.To clarify: it's easy to make the test fails 100% of the times with this change:
The fix proposed here is in line with other tests in hardlinks.test, as far as I can see all the tests use a trailing slash for the
$fromdirand$todirarguments.I tested that, after this commit, the test still catches the regression in rsync 3.4.0.
Fixes: #735