Dynamic and Filtering FirehoseDb Capability#153
Open
DavidIAm wants to merge 4 commits into
Open
Conversation
…n of them in the config file. Balance that potential security hole with whitelist and blacklist patterns that can exclude unwanted streams from inversion visibility.
christian-rp
approved these changes
Aug 14, 2023
| // our defined aliases | ||
| Stream.of(includeStreams.split(",")).map(part -> part.split("\\|")).forEach(arr -> nameActuals.add(Pair.of(arr[0], arr.length > 1 ? arr[1] : arr[0]))); | ||
|
|
||
| if (!empty(includeStreams)) |
There was a problem hiding this comment.
Nit picky, avoid indenting the business logic and exit empty if includeStreams is empty.
Contributor
Author
There was a problem hiding this comment.
Fair. The logic wasn't even relevant any more.
christian-rp
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add capability to FirehoseDb to operate on streams without declaration of them in the config file. Balance that potential security hole with whitelist and blacklist patterns that can exclude unwanted streams from inversion visibility.