Improve logging in the presence of HTTP GET timeouts#151
Open
christian-rp wants to merge 2 commits into
Open
Conversation
Author
|
Another thing worth noting that the hardcoded 30 second connection/socket timeout used in HttpUtils is being negated by the 10 second Future::get call in ElasticDb/ElasticsearchDb. Why are they different? |
eriknj
reviewed
Aug 7, 2023
| } catch (TimeoutException e) { | ||
| log.error("timed out waiting {} seconds for GET {} to complete", maxRequestDuration, allRequestUrl); | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
might be a silly question but what is the relationship between these two classes? could this change be single-sourced by putting the common elements into a reusable method accessible to both classes?
Author
There was a problem hiding this comment.
a very good question, I don't know the answer. At first glance, they do more/less the same thing.
DavidIAm
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.