fix: unknown slash commands crash & incorrect handling#1157
Open
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Open
fix: unknown slash commands crash & incorrect handling#1157deepak0x wants to merge 2 commits intoRocketChat:developfrom
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
hey @Spiral-Memory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the app crashed if a user typed an unknown slash command (for example,
/hello) and pressed Enter.Now, unknown slash commands are treated as command attempts instead of normal chat messages. If the command does not exist on the server, the user will see a "No such command" message.
Closes: #1144
Screenshots

Changes Made
1. packages/react/src/views/CommandList/CommandsList.js
handleKeyPress.2. packages/react/src/hooks/useShowCommands.js
3. packages/react/src/views/ChatInput/ChatInput.js
handleCommandExecution
sendMessage