feat: add clickable timestamp to quoted messages#1089
Open
Khizarshah01 wants to merge 2 commits intoRocketChat:developfrom
Open
feat: add clickable timestamp to quoted messages#1089Khizarshah01 wants to merge 2 commits intoRocketChat:developfrom
Khizarshah01 wants to merge 2 commits intoRocketChat:developfrom
Conversation
Collaborator
|
It's a great improvement, but currently it will not work properly if the message is not in the DOM. We need to implement proper virtualization of the message chat to prevent jumping behaviors. @deepak0x is working on it, so please coordinate with him to achieve this. Meanwhile, I'll review this PR. It will at least work when the message is loaded in the DOM. |
Contributor
Author
|
Since #1111 introduces react-virtuoso, I can adapt the quote navigation to use scrollToIndex once merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clickable timestamp to quoted messages
Fixes #1088
Video/Screenshots
Screencast.from.2026-01-20.00-33-38.mp4
Technical notes
This PR adds navigation to the original quoted message by locating the message element in the DOM using its message ID and scrolling to it when available.
Navigation works only when the original message is already loaded and rendered in the DOM
I explored whether there is an existing way to navigate to or load messages by ID in EmbeddedChat, but couldn’t find a suitable mechanism. If there is a recommended approach, I’d be happy to update the implementation
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.