Conversation
📝 WalkthroughWalkthroughA GitHub Actions CI/CD workflow file was modified to add disk-space cleanup for Android builds, adjust environment variables for web and Docker builds, replace dynamic with static Docker image references, and normalize formatting across release-notes and permission configuration lines. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/react-native-cicd.yml (1)
482-497:⚠️ Potential issue | 🟠 MajorGHCR login is now dead code; Docker Hub push has no fallback if creds are missing.
Since
imagesis now hardcoded toresgridllc/unit(Docker Hub only), the GHCR login step (lines 482–487) is unreachable/unused. More importantly, if Docker Hub credentials are unavailable, the push at line 504 will fail with no fallback — the credential check at line 464 sets an output but nothing gates thedocker/build-push-actionstep on it.Consider either:
- Removing the GHCR login if it's no longer needed, or re-adding a GHCR image target alongside Docker Hub.
- Gating the push step (or the entire
build-dockerjob) onsteps.docker-creds.outputs.available == 'true'.
🤖 Fix all issues with AI agents
In @.github/workflows/react-native-cicd.yml:
- Around line 429-442: Update the misleading comment that currently reads "Unset
DISPATCH_* env vars for web build..." to accurately reference the variables
being cleared (e.g., "Unset UNIT_* env vars for web build...") so it matches the
actual environment variables shown (UNIT_BASE_API_URL, UNIT_API_VERSION,
UNIT_RESGRID_API_URL, UNIT_CHANNEL_HUB_NAME, UNIT_REALTIME_GEO_HUB_NAME,
UNIT_LOGGING_KEY, UNIT_APP_KEY, UNIT_MAPBOX_PUBKEY, UNIT_MAPBOX_DLKEY,
UNIT_SENTRY_DSN, UNIT_COUNTLY_APP_KEY, UNIT_COUNTLY_SERVER_URL); no other
changes to the variable list are required.
| # Unset DISPATCH_* env vars for web build to use defaults from env.js | ||
| # Actual values will be injected at Docker container runtime via envsubst | ||
| UNIT_BASE_API_URL: '' | ||
| UNIT_API_VERSION: '' | ||
| UNIT_RESGRID_API_URL: '' | ||
| UNIT_CHANNEL_HUB_NAME: '' | ||
| UNIT_REALTIME_GEO_HUB_NAME: '' | ||
| UNIT_LOGGING_KEY: '' | ||
| UNIT_APP_KEY: '' | ||
| UNIT_MAPBOX_PUBKEY: '' | ||
| UNIT_MAPBOX_DLKEY: '' | ||
| UNIT_SENTRY_DSN: '' | ||
| UNIT_COUNTLY_APP_KEY: '' | ||
| UNIT_COUNTLY_SERVER_URL: '' |
There was a problem hiding this comment.
Comment references DISPATCH_* but the variables being unset are UNIT_*.
Line 429 says "Unset DISPATCH_* env vars" but every variable below is prefixed with UNIT_. This is misleading — update the comment to match the actual variable names.
- # Unset DISPATCH_* env vars for web build to use defaults from env.js
+ # Unset UNIT_* env vars for web build to use defaults from env.js📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Unset DISPATCH_* env vars for web build to use defaults from env.js | |
| # Actual values will be injected at Docker container runtime via envsubst | |
| UNIT_BASE_API_URL: '' | |
| UNIT_API_VERSION: '' | |
| UNIT_RESGRID_API_URL: '' | |
| UNIT_CHANNEL_HUB_NAME: '' | |
| UNIT_REALTIME_GEO_HUB_NAME: '' | |
| UNIT_LOGGING_KEY: '' | |
| UNIT_APP_KEY: '' | |
| UNIT_MAPBOX_PUBKEY: '' | |
| UNIT_MAPBOX_DLKEY: '' | |
| UNIT_SENTRY_DSN: '' | |
| UNIT_COUNTLY_APP_KEY: '' | |
| UNIT_COUNTLY_SERVER_URL: '' | |
| # Unset UNIT_* env vars for web build to use defaults from env.js | |
| # Actual values will be injected at Docker container runtime via envsubst | |
| UNIT_BASE_API_URL: '' | |
| UNIT_API_VERSION: '' | |
| UNIT_RESGRID_API_URL: '' | |
| UNIT_CHANNEL_HUB_NAME: '' | |
| UNIT_REALTIME_GEO_HUB_NAME: '' | |
| UNIT_LOGGING_KEY: '' | |
| UNIT_APP_KEY: '' | |
| UNIT_MAPBOX_PUBKEY: '' | |
| UNIT_MAPBOX_DLKEY: '' | |
| UNIT_SENTRY_DSN: '' | |
| UNIT_COUNTLY_APP_KEY: '' | |
| UNIT_COUNTLY_SERVER_URL: '' |
🤖 Prompt for AI Agents
In @.github/workflows/react-native-cicd.yml around lines 429 - 442, Update the
misleading comment that currently reads "Unset DISPATCH_* env vars for web
build..." to accurately reference the variables being cleared (e.g., "Unset
UNIT_* env vars for web build...") so it matches the actual environment
variables shown (UNIT_BASE_API_URL, UNIT_API_VERSION, UNIT_RESGRID_API_URL,
UNIT_CHANNEL_HUB_NAME, UNIT_REALTIME_GEO_HUB_NAME, UNIT_LOGGING_KEY,
UNIT_APP_KEY, UNIT_MAPBOX_PUBKEY, UNIT_MAPBOX_DLKEY, UNIT_SENTRY_DSN,
UNIT_COUNTLY_APP_KEY, UNIT_COUNTLY_SERVER_URL); no other changes to the variable
list are required.
|
Approve |
Summary by CodeRabbit