Skip to content

RU-T42 Docker build fix#217

Merged
ucswift merged 1 commit intomasterfrom
develop
Feb 10, 2026
Merged

RU-T42 Docker build fix#217
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Member

@ucswift ucswift commented Feb 10, 2026

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD build infrastructure for improved stability and performance
    • Enhanced build environment configuration and cleanup routines
    • Improved logging and consistency in release workflows

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

A GitHub Actions CI/CD workflow file was modified to add disk-space cleanup for Android builds, adjust environment variables for web and Docker builds, replace dynamic with static Docker image references, and normalize formatting across release-notes and permission configuration lines.

Changes

Cohort / File(s) Summary
Disk-space cleanup for Android
.github/workflows/react-native-cicd.yml
Added cleanup steps to remove large packages, Docker images, apt caches, and swap files with pre- and post-cleanup disk-space logging.
Environment variable configuration
.github/workflows/react-native-cicd.yml
Web and Docker build steps now set APP_ENV and UNIT_* variables to empty/default values for runtime environment configuration.
Docker metadata and image references
.github/workflows/react-native-cicd.yml
Replaced dynamic image resolution logic with static image reference (resgridllc/unit) in Docker metadata step.
Release-notes and formatting adjustments
.github/workflows/react-native-cicd.yml
Consolidated release-notes payload construction, added consistent logging/reporting, and normalized spacing in permission lines.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • github-actions

Poem

🐰 The workflow runs swift, with caches now clean,
Disk space preserved, a maintainer's dream!
Environment variables set with care and might,
Static references shine, the docker build's right.
CI/CD flows smooth, from checkout to deploy—
Automation perfected brings robotic joy! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a Docker build fix, which is one aspect of the changes, but the PR includes multiple significant modifications beyond Docker: disk-space cleanup, environment variable adjustments for web builds, and release-notes workflow adjustments. The title is partially related but does not capture the main scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/react-native-cicd.yml (1)

482-497: ⚠️ Potential issue | 🟠 Major

GHCR login is now dead code; Docker Hub push has no fallback if creds are missing.

Since images is now hardcoded to resgridllc/unit (Docker Hub only), the GHCR login step (lines 482–487) is unreachable/unused. More importantly, if Docker Hub credentials are unavailable, the push at line 504 will fail with no fallback — the credential check at line 464 sets an output but nothing gates the docker/build-push-action step on it.

Consider either:

  1. Removing the GHCR login if it's no longer needed, or re-adding a GHCR image target alongside Docker Hub.
  2. Gating the push step (or the entire build-docker job) on steps.docker-creds.outputs.available == 'true'.
🤖 Fix all issues with AI agents
In @.github/workflows/react-native-cicd.yml:
- Around line 429-442: Update the misleading comment that currently reads "Unset
DISPATCH_* env vars for web build..." to accurately reference the variables
being cleared (e.g., "Unset UNIT_* env vars for web build...") so it matches the
actual environment variables shown (UNIT_BASE_API_URL, UNIT_API_VERSION,
UNIT_RESGRID_API_URL, UNIT_CHANNEL_HUB_NAME, UNIT_REALTIME_GEO_HUB_NAME,
UNIT_LOGGING_KEY, UNIT_APP_KEY, UNIT_MAPBOX_PUBKEY, UNIT_MAPBOX_DLKEY,
UNIT_SENTRY_DSN, UNIT_COUNTLY_APP_KEY, UNIT_COUNTLY_SERVER_URL); no other
changes to the variable list are required.

Comment on lines +429 to +442
# Unset DISPATCH_* env vars for web build to use defaults from env.js
# Actual values will be injected at Docker container runtime via envsubst
UNIT_BASE_API_URL: ''
UNIT_API_VERSION: ''
UNIT_RESGRID_API_URL: ''
UNIT_CHANNEL_HUB_NAME: ''
UNIT_REALTIME_GEO_HUB_NAME: ''
UNIT_LOGGING_KEY: ''
UNIT_APP_KEY: ''
UNIT_MAPBOX_PUBKEY: ''
UNIT_MAPBOX_DLKEY: ''
UNIT_SENTRY_DSN: ''
UNIT_COUNTLY_APP_KEY: ''
UNIT_COUNTLY_SERVER_URL: ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Comment references DISPATCH_* but the variables being unset are UNIT_*.

Line 429 says "Unset DISPATCH_* env vars" but every variable below is prefixed with UNIT_. This is misleading — update the comment to match the actual variable names.

-          # Unset DISPATCH_* env vars for web build to use defaults from env.js
+          # Unset UNIT_* env vars for web build to use defaults from env.js
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Unset DISPATCH_* env vars for web build to use defaults from env.js
# Actual values will be injected at Docker container runtime via envsubst
UNIT_BASE_API_URL: ''
UNIT_API_VERSION: ''
UNIT_RESGRID_API_URL: ''
UNIT_CHANNEL_HUB_NAME: ''
UNIT_REALTIME_GEO_HUB_NAME: ''
UNIT_LOGGING_KEY: ''
UNIT_APP_KEY: ''
UNIT_MAPBOX_PUBKEY: ''
UNIT_MAPBOX_DLKEY: ''
UNIT_SENTRY_DSN: ''
UNIT_COUNTLY_APP_KEY: ''
UNIT_COUNTLY_SERVER_URL: ''
# Unset UNIT_* env vars for web build to use defaults from env.js
# Actual values will be injected at Docker container runtime via envsubst
UNIT_BASE_API_URL: ''
UNIT_API_VERSION: ''
UNIT_RESGRID_API_URL: ''
UNIT_CHANNEL_HUB_NAME: ''
UNIT_REALTIME_GEO_HUB_NAME: ''
UNIT_LOGGING_KEY: ''
UNIT_APP_KEY: ''
UNIT_MAPBOX_PUBKEY: ''
UNIT_MAPBOX_DLKEY: ''
UNIT_SENTRY_DSN: ''
UNIT_COUNTLY_APP_KEY: ''
UNIT_COUNTLY_SERVER_URL: ''
🤖 Prompt for AI Agents
In @.github/workflows/react-native-cicd.yml around lines 429 - 442, Update the
misleading comment that currently reads "Unset DISPATCH_* env vars for web
build..." to accurately reference the variables being cleared (e.g., "Unset
UNIT_* env vars for web build...") so it matches the actual environment
variables shown (UNIT_BASE_API_URL, UNIT_API_VERSION, UNIT_RESGRID_API_URL,
UNIT_CHANNEL_HUB_NAME, UNIT_REALTIME_GEO_HUB_NAME, UNIT_LOGGING_KEY,
UNIT_APP_KEY, UNIT_MAPBOX_PUBKEY, UNIT_MAPBOX_DLKEY, UNIT_SENTRY_DSN,
UNIT_COUNTLY_APP_KEY, UNIT_COUNTLY_SERVER_URL); no other changes to the variable
list are required.

@ucswift
Copy link
Member Author

ucswift commented Feb 10, 2026

Approve

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit bce67a3 into master Feb 10, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant