Fixes and improvements to 049 removing hazmat suit/714#241
Open
ChronoQuote wants to merge 2 commits into
Open
Conversation
- Use two new globals as removal timers instead of BlurTimer, which fixes the issue where having blurry vision from another source (e.g. 420-J) causes 049 to remove the hazmat suit/714 sooner, as well as the issue where wearing both items at once causes 049 to only spend time removing the hazmat suit - Hazmat suit now falls to the ground when removed by 049 instead of being inexplicably destroyed - 714 now falls to the ground when removed by 049 instead of remaining in player's inventory (not that it matters much since the player dies afterwards) - Add messages to make it clear to the player when an item is removed - Make removal voice lines play sooner, replacing the initial awkward silence on contact and ensuring 049 is able to play a "kidnap" voice line on kill - Previously, PrevState represented whether 049 had played a removal voice line, but it would reset to 2 the moment you backed away from 049, and would not allow both removal voice lines to play if you were wearing both items at once; now, ChannelPlaying checks are used instead, preventing removal voice lines from being spammable by repeatedly approaching and backing away from 049, and also allowing both removal voice lines to play
It was easy to pick up the dropped hazmat suit while dying after 049 removed it. This shouldn't be possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed + improved version of PR #179.
Before: https://streamable.com/cb18y1
After: https://streamable.com/v75oqp
4fe0648 Fixes and improvements to 049 removing hazmat suit/714
ffdb482 Remove ability to pick up items while dying
It was easy to pick up the dropped hazmat suit while dying after 049 removed it. This shouldn't be possible.