Skip to content

Update README.md#2

Open
adityagandhamal wants to merge 2 commits intoRedHenLab:masterfrom
adityagandhamal:master
Open

Update README.md#2
adityagandhamal wants to merge 2 commits intoRedHenLab:masterfrom
adityagandhamal:master

Conversation

@adityagandhamal
Copy link
Copy Markdown

Fixed typo

Fixed typo
Copy link
Copy Markdown

@peteruhrig peteruhrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article still missing: "predict THE emotional rating"

@adityagandhamal
Copy link
Copy Markdown
Author

Right. Nice catch there!

Copy link
Copy Markdown
Author

@adityagandhamal adityagandhamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file edited

@karaszka
Copy link
Copy Markdown
Member

Hey, I'm happy to merge this if you are both sure that you are satisfied with the text quality now.
Out of curiosity, is this a part of an effort of reusing the project, or are you just hunting for typos? (Tbh, I find the second counterproductive)

@adityagandhamal
Copy link
Copy Markdown
Author

hey @karaszka, I am a beginner in open source and I just wanted to try out contributing to open source organisations. I am preparing for next summer's GSoC, so as I was going through RedHenLab's github profile, I found this repo and noticed that it had some typos to be fixed and hence raised a PR.
Sorry for any inconvenience.

@karaszka
Copy link
Copy Markdown
Member

Ok, cool to know. I would suggest you to start with either opening issues for bugs in the code, or fixing issues that already exist in popular libraries that you use, e.g. numpy. There will surely be problems there that you can solve. Good luck with your preparations.

@adityagandhamal
Copy link
Copy Markdown
Author

Thank you for the advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants