Improvements in the code#1
Open
adobkin wants to merge 2 commits into
Open
Conversation
adobkin
commented
Oct 12, 2012
adobkin
commented
- In canPerformWithActivityItems added check that Readability is installed on a device, if not check, the item Readability is always visible to share sheet. Also added check that items of activityItems is kind of NSURL or NSString
- Changed method performActivity
- Constants ReadabilityActivityURI and ReadabilityActivityAdd declared as static
- In canPerformWithActivityItems added check that Readability is installed on a device, if not check, the item Readability is always visible to share sheet. Also added check that items of activityItems is kind of NSURL or NSString - Changed method performActivity - Constants ReadabilityActivityURI and ReadabilityActivityAdd declared as static
Contributor
|
Hey there, thanks for the pull request, I'm going to pass this along to Brendan for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.