fix: harden container shutdown cleanup#408
Open
cristibleotiu wants to merge 5 commits into
Open
Conversation
What changed: abort container restarts when runtime cleanup fails; preserve process, thread, and fixed-volume handles for retry; stop Docker log readers after container stop to avoid false cleanup failures. Why: prevent stuck or duplicate runtimes during restart and shutdown paths.
What changed: - keep failed container cleanup candidates retryable instead of dropping handles - make manual STOP/RESTART/config handling preserve cleanup state safely - restore sync support files from develop and add lifecycle/fixed-volume/sync regression coverage Why: - avoid leaked container subprocesses and preserve existing sync behavior while resolving the PR branch against develop
What changed: - merge origin/develop into the shutdown cleanup branch - keep hardened runtime cleanup/restart behavior while accepting develop sync updates - make the lifecycle timeout assertion robust to deadline-based joins Why: - clear the PR merge conflict against develop without weakening cleanup safeguards
What changed: - log extra tunnel cleanup success only when every tunnel stopped - add coverage for failed extra tunnel cleanup logging Why: - avoid misleading success logs in hardened cleanup paths
toderian
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: abort container restarts when runtime cleanup fails; preserve process, thread, and fixed-volume handles for retry; stop Docker log readers after container stop to avoid false cleanup failures.
Why: prevent stuck or duplicate runtimes during restart and shutdown paths.
PR summary:
matching core change.
legitimately need longer cleanup time.
shutdown hardening.