Add ROCm-Finance content to docs#117
Merged
Merged
Conversation
lpaoletti
reviewed
Apr 30, 2026
Contributor
lpaoletti
left a comment
lpaoletti
left a comment
There was a problem hiding this comment.
looks good - especially the images
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
randyh62
requested review from
amitkumar-amd and
srinivamd
and removed request for
srinivamd
marco-grond
requested changes
May 13, 2026
Contributor
marco-grond
left a comment
marco-grond
left a comment
There was a problem hiding this comment.
Looks good thanks! Added a few suggested changes - please use your discretion to decide what should be included.
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
marco-grond
requested changes
May 15, 2026
Co-authored-by: marco-grond <112654609+marco-grond@users.noreply.github.com>
marco-grond
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add ROCm-Finance, XGBoost, LightGBM, ThunderGBM.
The images are in the works.
Technical Details
Test Plan
Test Result
Submission Checklist