Closed
Conversation
Agent-Logs-Url: https://github.com/Q-FRC/QDash/sessions/61daaa64-0878-4b67-bef1-77bf2f52eac9 Co-authored-by: crueter <172450873+crueter@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
crueter
April 9, 2026 16:14
View session
Copilot stopped work on behalf of
crueter due to an error
April 9, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the indirection, split implementations, and general annoyances in the drag-and-drop / resize system.
Problem
The old code attached grid geometry functions (
validSpot,validResize,getPoint,getRect,resetValid) and thecurrentOpValidstate directly to theRepeaterelement (id: grid). This caused several problems:Repeateris a view component; using it as a calculation engine was confusing.BaseWidget.qmlandResizeComponent.qmlboth accessed the Repeater by its id (grid) from inside delegate components — the coupling was invisible without knowing the exact scope chain.ResizeComponent.qmlalso used bare model role names (row,column,rowSpan,colSpan) that are only accessible as implicit delegate scope properties, making data flow hard to trace.Changes
Tab.qmlvalidSpot,validResize,getPoint,getRect,resetValid) andlastOpSuccessfulstate from theRepeatertoTabitself.Repeaterid fromgridtowidgetRepeater(it now only renders widgets — no logic attached).BaseWidget.qmlgrid.*call withtab.*.row,column,rowSpan,colSpan) with explicitmodel.row,model.column,model.rowSpan,model.colSpan.ResizeComponent.qmlgrid.*call withtab.*.row/column/rowSpan/colSpandelegate-scope accesses with explicitwidget.mrow/widget.mcolumn/widget.mrowSpan/widget.mcolumnSpan.docs/drag-drop-architecture.md(new)Testing
No automated tests exist for this area; the logic is QML/UI-level. The refactoring is a pure rename/move — no algorithms were changed, only where the functions live and how they are referenced.