fix: JSON exit-code asymmetry in check_orphans and check_assets#60
Merged
PythonWoods-Dev merged 1 commit intomainfrom Apr 16, 2026
Merged
fix: JSON exit-code asymmetry in check_orphans and check_assets#60PythonWoods-Dev merged 1 commit intomainfrom
PythonWoods-Dev merged 1 commit intomainfrom
Conversation
Both commands now check finding severity (error vs warning) before deciding exit codes, consistent with check_references and check_snippets. Warnings no longer trigger Exit 1 in JSON mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_orphansandcheck_assetsin JSON mode now distinguisherrorvswarningseverity before deciding exit codescheck_referencesandcheck_snippetsRelated
Follows up on PR #55 (
--format jsonon individual check commands)