Features Icons in features panel#284
Open
LiranCaduri wants to merge 172 commits intoPythonFreeCourse:developfrom
Open
Features Icons in features panel#284LiranCaduri wants to merge 172 commits intoPythonFreeCourse:developfrom
LiranCaduri wants to merge 172 commits intoPythonFreeCourse:developfrom
Conversation
…nto style/grid
…nto style/grid
…tests according to the new objects, Changing front to get information from Day objects, Re-arranging calendar.html grid stracture to be render by weeks, adding js functionality for day view section, adding css effects on daily event display
…eek object, changing tests
…into feature/feature-panel
…into feature/feature-panel
…i/calendar into feature/feature-icon
…into feature/feature-panel
…i/calendar into feature/feature-icon
…into feature/feature-panel
…i/calendar into feature/feature-icon
…into feature/feature-icon
yammesicka
reviewed
Feb 26, 2021
Member
yammesicka
left a comment
yammesicka
left a comment
There was a problem hiding this comment.
Where are all the tests? :)
Contributor
Author
Tests are included and modified in the |
…into feature/feature-icon
…into feature/feature-icon
…into feature/feature-icon
yammesicka
requested changes
Mar 30, 2021
Comment on lines
+104
to
+108
| if (!infoBox.classList.contains('info-box')) { | ||
| infoBox.classList.add('info-box'); | ||
| } else { | ||
| infoBox.classList.remove('info-box'); | ||
| } |
| ), | ||
| ).scalar() | ||
|
|
||
| print(user_feature) |
| content='No additional settings for this one :)') | ||
|
|
||
| template = templates.get_template( | ||
| "partials/features_panels/" + template + '.html' |
Member
There was a problem hiding this comment.
Use fstrings & precommit hooks
| color: var(--primary); | ||
| } | ||
|
|
||
| .text-red {color: var(--negative)} |
Comment on lines
+5
to
+9
| if (elementsArray.includes(row)) { | ||
| return row.classList.remove("invisible"); | ||
| } else { | ||
| return row.classList.add("invisible"); | ||
| } |
| function searchFeature(searchValue, elements) { | ||
| const elementsArray = Array.from(elements); | ||
| const result = elementsArray.filter(element => { | ||
| return element.getElementsByClassName("row-feature-name")[0].innerHTML.toLowerCase().includes(searchValue); |
Member
There was a problem hiding this comment.
- Prefer innerText
- Split to lines
Comment on lines
+24
to
+33
| 'input', function (evt) { | ||
| const rows = document.getElementsByClassName("feature-row"); | ||
| const value = evt.target.value.trim().toLowerCase(); | ||
| if (!value) { | ||
| Array.from(rows).map(element => element.classList.remove("invisible")); | ||
| } else { | ||
| const result = searchFeature(value, rows); | ||
| displayResult(rows, result); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
Export the function to external function
Comment on lines
+64
to
+67
| if (action === "ADD") { | ||
| return new URL('/features/add', url); | ||
| } | ||
| return new URL('/features/delete', url); |
Member
There was a problem hiding this comment.
Move all the strings here to be constants
|
|
||
| function appandFeatures(){ | ||
| const baseURL = window.location.origin; | ||
| const route = new URL('/features/installed', baseURL); |
| @@ -1,8 +1,9 @@ | |||
| import pytest | |||
Member
There was a problem hiding this comment.
Please add tests to achieve 100% coverage for this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icons for Features in Feature Panel.
The icons provided by Ionicons.
With every change to Feature Panel branch this branch will update as well.
Please comment on icons related things only.
if you want to comment on features panel related things there is a PR for that.
Thank you all!
FRONT (by @aviadamar):
This panel allows you to view optional add-ons. Add, remove or customize features to your liking by clicking on the features icon in the navigation bar.