Introspection: add a CLI to generate stubs#5904
Conversation
70f0bd1 to
b5efccb
Compare
bc46553 to
27af589
Compare
|
Thanks, the binary implementation looks fine to me (and matches what I've done locally in testing previously). Some thoughts / questions:
|
Good question. Building in this repository and publish on pypi is likely the easiest and nicest way to go. This way
No,
Definitely. Done. I have also added some documentation for the new maturin features. |
|
@davidhewitt just a small up to make sure you have seen my answers. Sorry for that |
Useful for setuptools-rust Use it also for the integration tests
27af589 to
4ee4fab
Compare
4ee4fab to
c697543
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Makes sense, I think we can indeed ship on PyPI with the same version numbering we use for the rest of PyO3?
|
(That can be a follow-up, I guess) |
26abbc6 to
de92476
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
de92476 to
2897f00
Compare
@davidhewitt Done. I have written the publishing action and setup a "pending publisher" on Pypi. When the next release is done I can share the package with you. Relevant diff: 2897f00 |
Reverting this to merge. Will push it in a follow up MR. |
Useful for setuptools-rust
Use it also for the integration tests