add Sealed to pyclass traits

[luxedo]

Part of #3908

Adds Sealed to traits in impl_/pyclass.rs

[davidhewitt]

Thanks, a couple of these seals are probably not needed, the rest look good to me!

[davidhewitt]

This seal doesn't achieve anything it seals PyClassBaseType so creates circular logic.

I think it's ok to leave this trait un-sealed, any user-defined type could in principle implement it (maybe let's document it as such).

[davidhewitt]

It is expected for user-defined types to implement this trait (via the macros), so there's no point sealing it (it's not a closed set of implementations).

[davidhewitt]

Thanks, I think if you merge main CI will be green.

[codspeed-hq]

Merging this PR will degrade performance by 10.73%

❌ 1 regressed benchmark
✅ 104 untouched benchmarks
⏩ 1 skipped benchmark¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	bench_pyclass_create	3.9 µs	4.4 µs	-10.73%

---

_{Comparing luxedo:3908/seal-pyclass (a99c305) with main (962a535)}

Footnotes

1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

[davidhewitt]

Thanks!