Skip to content

Mix: add optional surface_following_distance #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BioCam merged 1 commit into from
Jun 11, 2026
+11 −0
Merged

Mix: add optional surface_following_distance #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pylabrobot/liquid_handling/standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,20 @@ class SingleChannelDispense:

@dataclass(frozen=True)
class Mix:
"""Repeated aspirate/dispense cycles to mix the liquid during a transfer.

Args:
volume: The volume drawn then expelled each cycle.
repetitions: The number of aspirate/dispense cycles.
flow_rate: The flow rate of the mix.
surface_following_distance: The distance (mm) the tip follows the liquid surface each cycle on
backends that support it (e.g. Hamilton STAR); others ignore it.
Comment on lines +83 to +84

@rickwierenga rickwierenga Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other backends should not just ignore things when they dont support it, they should raise errors when the value is not None

should we clarify the direction as well? probably negative for going down?

@BioCam BioCam Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the raising but that would be part of each "wire into backend x PR"

I don't think the value should be negative because the direction seems to be always dictated by the atomic command:
Aspirate has to follow downwards
Dispense has to follow upwards
Because that is "following the surface" by definition
And mixing is defined as repeated aspirate-dispense cycles

"""

volume: float
repetitions: int
flow_rate: float
surface_following_distance: Optional[float] = None


@dataclass(frozen=True)
Expand Down
Loading