v1: add star.iswap.configuration and the STARConfiguration injection container#1083
Open
BioCam wants to merge 2 commits into
Open
v1: add star.iswap.configuration and the STARConfiguration injection container#1083BioCam wants to merge 2 commits into
star.iswap.configuration and the STARConfiguration injection container#1083BioCam wants to merge 2 commits into
Conversation
Introduce the iSWAPConfiguration dataclass holding iSWAP device facts (per-increment resolutions, drive/speed/acceleration ranges, geometric constants) and per-machine calibration, exposed as iSWAPBackend.configuration. This is the foundation the iSWAP read and move commands depend on. Per-machine fields carry Hamilton factory defaults pending EEPROM population at setup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…gh the device Introduce STARConfiguration (driver.py): one optional field per capability, named after the capability attribute (iswap), injected at construction and distributed to each backend as its `.configuration`. Thread it through STARDriver, STARChatterboxDriver, and the STAR/STARLet device, replacing the standalone chatterbox iswap kwarg. The container is injection-only (held privately as `_configuration`); the runtime home stays `star.iswap.configuration`. Add the iswap module docstring. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes the per-capability configuration layer for the STAR iSWAP - the v1 equivalent of v0's
iSWAPInformation- plus the device-level container for injecting it. This PR adds the configuration only; it does not change any existing command behaviour.iSWAPConfiguration(iswap.py): the iSWAP's device facts (encoder resolutions, drive/speed/acceleration ranges, geometric constants) and per-machine calibration, exposed asiSWAPBackend.configuration. Per-machine fields carry Hamilton factory defaults pending EEPROM population at setup.STARConfiguration(driver.py): one optional field per capability, named after the capability attribute (iswap), injected at construction viaSTAR/STARLet/driver and distributed to each backend as its.configuration. Injection-only (held privately); the runtime home staysstar.iswap.configuration. Grows one field per capability as each gains a configuration.Additive and behaviour-preserving: existing commands are unchanged, zero-config construction still works (factory defaults), and the chatterbox accepts a custom
configurationfor simulation. The full STAR test suite passes; the red CI lint/typecheck are pre-existing base breakages unrelated to this change.🤖 Generated with Claude Code