Populate STAR X-drives (X0) error trace table#1080
Merged
Conversation
The X0 module had no trace-information table, so every X-drive firmware error surfaced as "Unknown trace information code N". Add the table covering both firmware generations: per-drive init / not-initialized / movement / position / dispense-on-fly codes for X drive 1, X drive 2 and the reserve drive, plus the transfer, download, syntax, stop and parallel-process codes. Older-firmware-only and XE167-only codes do not collide, so a single table serves both. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X-drives (
X0) module had no entry intrace_information_to_string, so every X-drive firmware error surfaced to the user as the opaqueUnknown trace information code <n>.This PR adds the
X0table. X moves happen on essentially every operation, so an X-drive fault is something a user can plausibly hit, which makes this the most worthwhile of the previously-untabled modules.The table covers both firmware generations of the module - the original (
E289003a) and the XE167 controller (E2891005a) - in a single additive block: per-drive initialization / not-initialized / movement / position / dispense-on-fly codes for X drive 1 (50-55), X drive 2 (70-75) and the reserve drive (80-82), plus the transfer, download, syntax, stop and parallel-process codes. The codes that exist on only one generation do not overlap, and the codes shared by both mean the same thing, so one table serves both without any firmware-version gating.The change is additive: a new
elifbranch at the end of the dispatch chain. It alters no other module branch and changes no error classification or control flow - X-drive errors that previously printedUnknown trace information code <n>now print the real cause. Dispatch is keyed by module identifier, so these codes do not collide with the identically-numbered codes in the other module tables.🤖 Generated with Claude Code